Fix react native menu component
New here? Learn about Bountify and follow @bountify to get notified of new bounties! x

The menu component works fine in this demo https://codypearce.github.io/material-bread/?path=/story/components-menu--menu

But when applied to the app bar, you can see the second menu on the page does not appear where it should https://codypearce.github.io/material-bread/?path=/story/components-appbar--with-menu.

Additionally the menu component overlay seems to get stuck on this page. http://material-bread.org/components/appbar/#menu. This is probably because of the clickoutside logic.

So I'd like these two issues fixed:

  1. The menu component shows in the correct place in all demos.
  2. Fix clickoutside logic on appbar page.

You can also make a pr on the project for these fixes if you want some open source contributions.

Extra tips:

  1. Implement device edge away logic like on this project https://github.com/mxck/react-native-material-menu.
  2. Other improvements to this component.

Thanks!

awarded to minhtc

Crowdsource coding tasks.

2 Solutions

Winning solution

Checkout my pull request if it's what you need: https://github.com/codypearce/material-bread/pull/110

Thanks! Seems like a simple solution, sometimes it's hard to see though after you've been working on it so much. Thanks again!
outisflippa 3 months ago
yeap, seem like it's big and very complex projects
minhtc 3 months ago

This one for implement device edge away logic : https://github.com/codypearce/material-bread/pull/111
(only left or right edge currently)

Awesome, are you working on the top and bottom or should I merge that PR and tip?
outisflippa 3 months ago
The modal height inside storybook is not correct. I cant make it run on iOS simulator now, so I will leave it for another day.
minhtc 3 months ago
Alright thanks!
outisflippa 3 months ago
View Timeline